Browse Source

Task/remove deprecated activities from portfolio holding response (#6157)

* Remove deprecated activities

* Update changelog
pull/6160/merge
Thomas Kaul 2 days ago
committed by GitHub
parent
commit
f19e417068
No known key found for this signature in database GPG Key ID: B5690EEEBB952194
  1. 1
      CHANGELOG.md
  2. 1
      apps/api/src/app/portfolio/portfolio.service.ts
  3. 4
      libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts
  4. 15
      libs/ui/src/lib/services/data.service.ts

1
CHANGELOG.md

@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Removed the deprecated platforms from the info service - Removed the deprecated platforms from the info service
- Removed the deprecated activities from the endpoint `GET api/v1/portfolio/holding/:dataSource/:symbol`
## 2.230.0 - 2026-01-14 ## 2.230.0 - 2026-01-14

1
apps/api/src/app/portfolio/portfolio.service.ts

@ -920,7 +920,6 @@ export class PortfolioService {
marketPriceMin, marketPriceMin,
SymbolProfile, SymbolProfile,
tags, tags,
activities: activitiesOfHolding,
activitiesCount: transactionCount, activitiesCount: transactionCount,
averagePrice: averagePrice.toNumber(), averagePrice: averagePrice.toNumber(),
dataProviderInfo: portfolioCalculator.getDataProviderInfos()?.[0], dataProviderInfo: portfolioCalculator.getDataProviderInfos()?.[0],

4
libs/common/src/lib/interfaces/responses/portfolio-holding-response.interface.ts

@ -1,5 +1,4 @@
import { import {
Activity,
Benchmark, Benchmark,
DataProviderInfo, DataProviderInfo,
EnhancedSymbolProfile, EnhancedSymbolProfile,
@ -9,9 +8,6 @@ import {
import { Tag } from '@prisma/client'; import { Tag } from '@prisma/client';
export interface PortfolioHoldingResponse { export interface PortfolioHoldingResponse {
/** @deprecated */
activities: Activity[];
activitiesCount: number; activitiesCount: number;
averagePrice: number; averagePrice: number;
dataProviderInfo: DataProviderInfo; dataProviderInfo: DataProviderInfo;

15
libs/ui/src/lib/services/data.service.ts

@ -424,21 +424,8 @@ export class DataService {
dataSource: DataSource; dataSource: DataSource;
symbol: string; symbol: string;
}) { }) {
return this.http return this.http.get<PortfolioHoldingResponse>(
.get<PortfolioHoldingResponse>(
`/api/v1/portfolio/holding/${dataSource}/${symbol}` `/api/v1/portfolio/holding/${dataSource}/${symbol}`
)
.pipe(
map((data) => {
if (data.activities) {
for (const order of data.activities) {
order.createdAt = parseISO(order.createdAt as unknown as string);
order.date = parseISO(order.date as unknown as string);
}
}
return data;
})
); );
} }

Loading…
Cancel
Save