Refactoring

apps/api/src/app/portfolio/portfolio.service.ts

@@ -1358,7 +1358,7 @@ export class PortfolioService {
           [
             new EmergencyFundSetup({
               languageCode,
-              emergencyFund: totalEmergencyFundInBaseCurrency,
+              emergencyFundInBaseCurrency: totalEmergencyFundInBaseCurrency,
               exchangeRateDataService: this.exchangeRateDataService,
               i18nService: this.i18nService
             }),

apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts

@@ -4,28 +4,28 @@ import { I18nService } from '@ghostfolio/api/services/i18n/i18n.service';
 import { RuleSettings } from '@ghostfolio/common/interfaces';
 
 export class EmergencyFundSetup extends Rule<Settings> {
-  private emergencyFund: number;
+  private emergencyFundInBaseCurrency: number;
   private i18nService: I18nService;
 
   public constructor({
-    emergencyFund,
+    emergencyFundInBaseCurrency,
     exchangeRateDataService,
     i18nService,
     languageCode
   }: {
-    emergencyFund: number;
+    emergencyFundInBaseCurrency: number;
     exchangeRateDataService: ExchangeRateDataService;
     i18nService: I18nService;
     languageCode: string;
   }) {
     super({ exchangeRateDataService, languageCode, key: 'EmergencyFundSetup' });
 
-    this.emergencyFund = emergencyFund;
+    this.emergencyFundInBaseCurrency = emergencyFundInBaseCurrency;
     this.i18nService = i18nService;
   }
 
   public evaluate() {
-    if (!this.emergencyFund) {
+    if (!this.emergencyFundInBaseCurrency) {
       return {
         evaluation: this.i18nService.getTranslation({
           id: 'rule.emergencyFundSetup.false',