Browse Source

resolve comments

pull/7309/head
KenTandrian 2 days ago
parent
commit
f6f7c100c6
  1. 2
      apps/client/src/app/pages/portfolio/activities/activities-page.component.ts
  2. 2
      apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
  3. 4
      apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/interfaces/interfaces.ts

2
apps/client/src/app/pages/portfolio/activities/activities-page.component.ts

@ -92,7 +92,7 @@ export class GfActivitiesPageComponent implements OnInit {
.pipe(map((activity) => ({ activity, params }))); .pipe(map((activity) => ({ activity, params })));
} }
return of({ activity: undefined, params }); return of({ params, activity: undefined });
}) })
) )
.subscribe(({ activity, params }) => { .subscribe(({ activity, params }) => {

2
apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts

@ -537,9 +537,11 @@ export class GfCreateOrUpdateActivityDialogComponent {
this.dialogRef.close(activity); this.dialogRef.close(activity);
} else { } else {
const activityId = this.data.activity?.id; const activityId = this.data.activity?.id;
if (!activityId) { if (!activityId) {
throw new Error('Activity ID is required for update'); throw new Error('Activity ID is required for update');
} }
(activity as UpdateOrderDto).id = activityId; (activity as UpdateOrderDto).id = activityId;
await validateObjectForForm({ await validateObjectForForm({

4
apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/interfaces/interfaces.ts

@ -4,10 +4,10 @@ import { Account } from '@prisma/client';
export interface CreateOrUpdateActivityDialogParams { export interface CreateOrUpdateActivityDialogParams {
accounts: Account[]; accounts: Account[];
activity: Partial<Omit<Activity, 'SymbolProfile' | 'id' | 'unitPrice'>> & { activity: Partial<Omit<Activity, 'id' | 'SymbolProfile' | 'unitPrice'>> & {
id: string | null; id: string | null;
unitPrice: number | null;
SymbolProfile: Activity['SymbolProfile'] | null; SymbolProfile: Activity['SymbolProfile'] | null;
unitPrice: number | null;
}; };
user: User; user: User;
} }

Loading…
Cancel
Save