Fix average price for short positions

apps/api/src/app/portfolio/calculator/portfolio-calculator.ts

@@ -926,14 +926,22 @@ export abstract class PortfolioCalculator {
           .mul(factor)
           .plus(oldAccumulatedSymbol.quantity);
 
-        if (type === 'BUY') {
+        if (type === 'BUY' && oldAccumulatedSymbol.investment.gte(0)) {
           investment = oldAccumulatedSymbol.investment.plus(
             quantity.mul(unitPrice)
           );
-        } else if (type === 'SELL') {
+        } else if (type === 'BUY' && oldAccumulatedSymbol.investment.lt(0)) {
+          investment = oldAccumulatedSymbol.investment.plus(
+            quantity.mul(oldAccumulatedSymbol.averagePrice)
+          );
+        } else if (type === 'SELL' && oldAccumulatedSymbol.investment.gt(0)) {
           investment = oldAccumulatedSymbol.investment.minus(
             quantity.mul(oldAccumulatedSymbol.averagePrice)
           );
+        } else if (type === 'SELL' && oldAccumulatedSymbol.investment.lte(0)) {
+          investment = oldAccumulatedSymbol.investment.minus(
+            quantity.mul(unitPrice)
+          );
         }
 
         currentTransactionPointItem = {
@@ -942,8 +950,8 @@ export abstract class PortfolioCalculator {
           investment,
           skipErrors,
           symbol,
-          averagePrice: newQuantity.gt(0)
+          averagePrice: !newQuantity.eq(0)
-            ? investment.div(newQuantity)
+            ? investment.div(newQuantity).abs()
             : new Big(0),
           dividend: new Big(0),
           fee: oldAccumulatedSymbol.fee.plus(fee),