Automatically build and publish to Github Container Registry #213

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

For every commit on a branch for which there is a pull request to the master, a new image is built.
Shouldn't be like this, only when pushing commits to the master (merge commits)

IMO we should do it, because build on Windows is different from building on Linux container

Building the container only on specific branches (ie master/main/dev) means that there is very exact control over when a new image gets built, and anyone attempting to put up a devious image would have to have get it to pass code review. Much harder for someone to accidentally get a devious image.

Images are deliberately built for each PR so that they can be tested before releasing.

Failure to do so could result in underlying issues with the container (glibc / nodejs upgrade at the is level etc) breaking the deployment and unless we test at PR level then we would only find this out after the "production" container has been released.

Building and testing on branches is an established pattern within the ci/cd community because it brings value without adding unnecessary complication.

To specifically address your point about "bad" images, all images built from a PR would tagged with the PR number and result in the format uptime-kuma:PR-3, this means that someone would have to deliberately update their configuration to pull these images, and would never see them otherwise, even if their setup was configured for uptime-kuma:latest.

As the code would not be merged until after a review, the chances of a "bad" container making it through to release is just as likely as "bad" code making it through, at which point it stops being an issue with how we package and publish and becomes an issue with how we review the code.

I'm used to a PR -> dev/nightly -> master/main process. All steps are still done before prod, in dev/nightly. Everything is still fully tested, including the container builds. Some things however, like steps accessing keys or pushing test images to public, wait for code review & approval/merging to dev before running.

I don't like the possibility of ANY container potentially containing un-reviewed code being public. Its unlikely, but we shouldn't assume someone won't just sort by newest tag and use that. Imagine someone un-experienced, who doesn't know git[hub/lab] reversing PR to mean Public Release instead of Pull Request. The more I think on it, the more I am against blindly pushing PRs to the registry.

an established pattern within the ci/cd community

Can you link some other projects that are using this process please? I will still be paranoid, but I will withdraw my comments if this is indeed a commonly accepted pattern.

Sorry if I'm overly security paranoid, but it pays to be so nowadays unfortunately.

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This should be wrapped in an IF statement like:

- if: github.event_name != 'pull_request'
  name: Login to Docker Hub

That way it doesnt try to login into ghcr.io on every pull-request.

See comment above - we should be logging in, building, and pushing an image for every PR in order to ensure confidence in the platform.

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This should be:

${{ github.event_name != 'pull_request' }}

Else every pull-request is going to try to Push an image.

Yup, that's deliberate, it means we can test the code for each PR in a dedicated docker image rather than waiting for the code to reach main/master before we know if the container works properly.

The problem is that building and push an image per PR will create a lot of unused tags in the registry. The latest changes made by @louislam are now testing/linting the code using Github Actions which should cover your use-case.

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

OK, so let's say I'm working on a PR, I push that code up, it lints/tests fine via Github actions, and we merge to master.

We then find that there's an issue with the container setup rather than the code (libc version change or something equally obscure), but we only find that out after it's been released to the wider world and causes a slew of github issues to be created.

If we create a container on each PR (and note that this is each PR, not each commit, it is rebuilt with the same tags each time) then we can test that the container itself works as well.

I'm really not convinced that "too many tags in the registry" is a strong enough argument when the alternative is a falling deployment for users of the application?

Happy to change this, good spot, thanks :)

Fair enough, we do this against a private registry instead of a public one. I do get your point.

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

Can we use multiline array here (or list like for branches)?

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Maybe add a docker layer caching like this?

cache-from: type=gha, scope=${{ github.workflow }}
cache-to: type=gha, mode=max, scope=${{ github.workflow }}

This should save some time on pulling.
Reference: Cache eviction policy

The cache policy is experimental though

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

Uptime is missing the e

Good catch, I'll fix this when I'm back at a computer

Resolved in latest commit

This won't work, because the main branch for uptime-kuma is master. You can replace it with:

type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}

That way it doesn't matter if master or main is the default branch.

Happy to change this, good spot, thanks :)

 @ -0,0 +1,74 @@
 # This is a basic workflow to help you get started with Actions
 name: Build and deploy containers
 # Controls when the action will run.
 on:
   push:
     branches:
       - 'master'
   pull_request:
     branches:
       - master
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
   # This workflow contains a single job called "build"
   build:
     # The type of runner that the job will run on
     runs-on: ubuntu-latest
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
       - name: Check Out Repo
         uses: actions/checkout@v2
       -
         name: Docker meta
         id: meta
         uses: docker/metadata-action@v3
         with:
           # list of Docker images to use as base name for tags
           images: |
             ghcr.io/louislam/uptime-kuma
           # generate Docker tags based on the following events/attributes
           tags: |
             type=schedule
             type=ref,event=branch
             type=ref,event=pr
             type=semver,pattern={{version}}
             type=semver,pattern={{major}}.{{minor}}
             type=semver,pattern={{major}}
             type=sha
             type=raw,value=latest,enable=${{ endsWith(github.ref, github.event.repository.default_branch) }}
       - name: Login to Docker Hub
         uses: docker/login-action@v1
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
       - name: Set up QEMU
         uses: docker/setup-qemu-action@master
         with:
           platforms: all
       - name: Set up Docker Buildx
         id: buildx
         uses: docker/setup-buildx-action@v1
       - name: Build and push
         id: docker_build
         uses: docker/build-push-action@v2
         with:
           context: ./
           file: ./docker/dockerfile
           push: true
           platforms: linux/amd64, linux/arm/v7, linux/arm/v6, linux/arm64
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
       - name: Image digest
         run: echo ${{ steps.docker_build.outputs.digest }}

Automatically build and publish to Github Container Registry #213

74 .github/workflows/container_build.yml View File

74

.github/workflows/container_build.yml

View File