topaLE
/
uptime-kuma
1
0
Fork 0
Code Issues 185 Pull Requests 26 Projects Releases 28 Wiki Activity
Labels Milestones

add release config #38

Open
philippdormann wants to merge 3 commits from philippdormann/feature/release-management into master
Conversation 5 Commits 3 Files Changed 2
philippdormann commented 4 years ago (Migrated from github.com)
Owner
  • automated changelog containing commits + diff from last release
  • automated version bumping
  • tag creation
    • might be used to trigger GitHub workflows/ GitHub Actions for Docker releases in the future?
  • semver support
- automated changelog containing commits + diff from last release - automated version bumping - tag creation - might be used to trigger GitHub workflows/ GitHub Actions for Docker releases in the future? - semver support
👍 6
Saibamen commented 4 years ago (Migrated from github.com)
Owner

@philippdormann: Please resolve conflicts

@louislam: +1 for this. This will take care of correct releases in GitHub.
Current release is wrong:
image

@philippdormann: Please resolve conflicts @louislam: +1 for this. This will take care of correct releases in GitHub. Current release is wrong: ![image](https://user-images.githubusercontent.com/905878/128191422-448b1ed2-67b4-441d-a218-378f976668ff.png)
philippdormann commented 4 years ago (Migrated from github.com)
Poster
Owner

thanks for stepping in and "+1'ing" 😉

sure thing :) will resolve the conflicts shortly

thanks for stepping in and "+1'ing" 😉 sure thing :) will resolve the conflicts shortly
Saibamen (Migrated from github.com) requested changes 4 years ago
package.json
Saibamen (Migrated from github.com) commented 4 years ago
Owner

Please move it to devDependencies. We don't want to have unused packaged in PROD Docker image (https://github.com/louislam/uptime-kuma/pull/122)

Please also add ^ before versions

Please move it to devDependencies. We don't want to have unused packaged in PROD Docker image (https://github.com/louislam/uptime-kuma/pull/122) Please also add `^` before versions
nicolaiort (Migrated from github.com) reviewed 4 years ago
package.json
nicolaiort (Migrated from github.com) commented 4 years ago
Owner

The two dependencies you mentioned are already devDependencies :)

The two dependencies you mentioned are already devDependencies :)
Saibamen (Migrated from github.com) approved these changes 4 years ago
Saibamen (Migrated from github.com) left a comment

LGTM

Saibamen (Migrated from github.com) reviewed 4 years ago
package.json
Saibamen (Migrated from github.com) commented 4 years ago
Owner

Sorry, I didn't see full file before :P

Sorry, I didn't see full file before :P
nicolaiort (Migrated from github.com) approved these changes 4 years ago
nicolaiort (Migrated from github.com) left a comment

the new release configs are nice

louislam commented 4 years ago (Migrated from github.com)
Owner

Since my release approach is a bit special, I have my own script for that. Will be back to this later.

Since my release approach is a bit special, I have my own script for that. Will be back to this later.
Saibamen commented 4 years ago (Migrated from github.com)
Owner

@philippdormann: Can you check https://github.com/louislam/uptime-kuma/blob/master/extra/update-version.js and https://github.com/louislam/uptime-kuma/blob/master/extra/mark-as-nightly.js to see how current release looks like?

@philippdormann: Can you check https://github.com/louislam/uptime-kuma/blob/master/extra/update-version.js and https://github.com/louislam/uptime-kuma/blob/master/extra/mark-as-nightly.js to see how current release looks like?
philippdormann commented 4 years ago (Migrated from github.com)
Poster
Owner

well of course I took a look at it and
tbh don't like it at all - that's why this PR was created 😄😬

well of course I took a look at it and tbh don't like it at all - that's why this PR was created 😄😬
👍 4

Reviewers

Saibamen
nicolaiort
This pull request has changes conflicting with the target branch.
package-lock.json
package.json
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Saibamen
nicolaiort
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion doc
Improvements or additions to documentation duplicate
This issue or pull request already exists feature-request
New feature or request good first issue
Good for newcomers hacktoberfest hacktoberfest-accepted help help wanted
Extra attention is needed High
High Priority impossible invalid
This doesn't seem right investigating k8s Low
Low Priority Medium
Medium Priority News prerelease bug question
Further information is requested resolved Unknown wontfix
This will not be worked on
No Label bug dependencies discussion doc duplicate feature-request good first issue hacktoberfest hacktoberfest-accepted help help wanted High impossible invalid investigating k8s Low Medium News prerelease bug question resolved Unknown wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'philippdormann/feature/release-management'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes