Labels Milestones

fix(heartbeat-bar): fix margin-bottom & right without break animation #612

Open

bertyhell wants to merge 6 commits from bertyhell/bugfix/heartbeat-bar-animation into master

pull from: bertyhell/bugfix/heartbeat-bar-animation

merge into: topaLE:master

topaLE:1.6.X

topaLE:1.7.X

topaLE:1.9.X

topaLE:Mikhail5555/feature/remote-header-auth

topaLE:Nuckerr/master

topaLE:Saibamen/fix_871

topaLE:WillianRod/feat/add-favicon-badges

topaLE:andreasbrett/logging

topaLE:andreasbrett/securepush

topaLE:bertyhell/feature/monitor-checks

topaLE:bertyhell/feature/translations-extraction-script

topaLE:cert-notification

topaLE:chakflying/settings-redesign

topaLE:debian-docker

topaLE:deefdragon/Template-Engine

topaLE:deefdragon/notif-tests

topaLE:e2e-test

topaLE:fdcastel/push-api-tags

topaLE:free-disk-space

topaLE:ivanbratovic/http-basicauth

topaLE:ivanbratovic/improve-translatables

topaLE:k8s-unofficial

topaLE:lucasra1/overall_status

topaLE:master

topaLE:mhkarimi1383/master

topaLE:mrphuongbn/master

topaLE:no-need-build

topaLE:philippdormann/feature/release-management

topaLE:proffalken/feature/680_add_labels_to_prometheus_metrics

topaLE:proffalken/feature/auto_build_and_release

topaLE:rebasesoftware/feature/request-with-http-proxy

topaLE:restructure-status-page

topaLE:sqlite-upgrade-prebuilt

topaLE:tarun7singh/master

topaLE:thomasleveil/feature/565-duplicate-monitor

topaLE:thomasleveil/ux/add-group-at-the-top

Conversation 0 Commits 6 Files Changed 2

bertyhell commented 3 years ago (Migrated from github.com)

Owner

This PR tried to fix some styling issues with the hearth beat bar: https://github.com/louislam/uptime-kuma/pull/521

Unfortunately it broke the new heartbeat animation.

broken animation:
https://user-images.githubusercontent.com/1710840/136654099-b3947c1a-b660-4388-b7c2-52c882b185d7.mp4

@louislam reverted some of the style changes to fix the animation.

current animation on the master branch:
https://user-images.githubusercontent.com/1710840/136654107-06213e06-c235-4912-adaa-b2f6935b6b49.mp4

But in doing so he also reverted the vertical padding fix.

This PR tries to fix both issues:

• the animation
• and the vertical padding

The animation after this PR:
https://user-images.githubusercontent.com/1710840/136654111-1eb609ae-4476-4a4b-993b-b2c8da33495d.mp4

The vertical padding after this PR:

This PR tried to fix some styling issues with the hearth beat bar: https://github.com/louislam/uptime-kuma/pull/521 Unfortunately it broke the new heartbeat animation. broken animation: https://user-images.githubusercontent.com/1710840/136654099-b3947c1a-b660-4388-b7c2-52c882b185d7.mp4 @louislam reverted some of the style changes to fix the animation. current animation on the master branch: https://user-images.githubusercontent.com/1710840/136654107-06213e06-c235-4912-adaa-b2f6935b6b49.mp4 But in doing so he also reverted the vertical padding fix.   This PR tries to fix both issues: * the animation * and the vertical padding The animation after this PR: https://user-images.githubusercontent.com/1710840/136654111-1eb609ae-4476-4a4b-993b-b2c8da33495d.mp4 The vertical padding after this PR: 

👍 4

This pull request can be merged automatically.

You are not authorized to merge this pull request.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels

bug
Something isn't working dependencies
Pull requests that update a dependency file discussion doc
Improvements or additions to documentation duplicate
This issue or pull request already exists feature-request
New feature or request good first issue
Good for newcomers hacktoberfest hacktoberfest-accepted help help wanted
Extra attention is needed High
High Priority impossible invalid
This doesn't seem right investigating k8s Low
Low Priority Medium
Medium Priority News prerelease bug question
Further information is requested resolved Unknown wontfix
This will not be worked on

No Label bug dependencies discussion doc duplicate feature-request good first issue hacktoberfest hacktoberfest-accepted help help wanted High impossible invalid investigating k8s Low Medium News prerelease bug question resolved Unknown wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.