topaLE
/
uptime-kuma
1
0
Fork 0
Code Issues 185 Pull Requests 26 Projects Releases 28 Wiki Activity
Labels Milestones

Add badges to favicon #835

Open
WillianRod wants to merge 1 commits from WillianRod/feat/add-favicon-badges into master
Conversation 4 Commits 1 Files Changed 4
WillianRod commented 4 years ago (Migrated from github.com)
Owner

Description

Resolves #728

  • Added favicon badges counter

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image
image

# Description Resolves #728 - Added favicon badges counter ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] My code follows the style guidelines of this project - [x] I ran ESLint and other linters for modified files - [x] I have performed a self-review of my own code and test it - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] My changes generate no new warnings - [ ] My code needed automated testing. I have added them (this is optional task) ## Screenshots (if any) ![image](https://user-images.githubusercontent.com/6539258/139515802-b669d92f-4910-4570-a306-5a3c8d042ace.png) ![image](https://user-images.githubusercontent.com/6539258/139515808-9534bee1-89c0-450b-8bd0-786d104b48df.png)
🚀 1
deefdragon commented 4 years ago (Migrated from github.com)
Owner

It looks good so far, but I am gonna ask that you add an option to enable/disable this.

Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors.

It looks good so far, but I am gonna ask that you add an option to enable/disable this. Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors.
WillianRod commented 4 years ago (Migrated from github.com)
Poster
Owner

It looks good so far, but I am gonna ask that you add an option to enable/disable this.

Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors.

The Favicon library automatically hide the badge when 0 is passed.

An option to hide it could be interesting, but this badge is a more visual way to call attention when a monitor goes down.

> It looks good so far, but I am gonna ask that you add an option to enable/disable this. > > > > Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors. The Favicon library automatically hide the badge when 0 is passed. An option to hide it could be interesting, but this badge is a more visual way to call attention when a monitor goes down.
Saibamen (Migrated from github.com) reviewed 4 years ago
src/pages/StatusPage.vue
Saibamen (Migrated from github.com) commented 4 years ago
Owner 
    animation: "none",
```suggestion animation: "none", ```
Saibamen (Migrated from github.com) approved these changes 4 years ago
deefdragon commented 4 years ago (Migrated from github.com)
Owner

It looks good so far, but I am gonna ask that you add an option to enable/disable this.
Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors.

The Favicon library automatically hide the badge when 0 is passed.

Understood.

An option to hide it could be interesting, but this badge is a more visual way to call attention when a monitor goes down.

So, my brain is annoyingly reliant on something's general color and shape for recognition (especially in icons like favicons/profile pics), and adding this badge may make it more difficult for me figure out which of my billion tabs has UK on it when I get a ping if I want more details. Its possible that this won't actually impact things, but I would rather have the option than not.

Its minor, and I can definitely see the trade-off of settings clutter vs configuration, but I just want to explain why I want the option in a bit more detail.

> > It looks good so far, but I am gonna ask that you add an option to enable/disable this. > > Also, looking at the code real quick, it looks like it always displays a number, even if there are 0 down. I think it should probably remove the badge if there are no down monitors. > > The Favicon library automatically hide the badge when 0 is passed. Understood. > An option to hide it could be interesting, but this badge is a more visual way to call attention when a monitor goes down. So, my brain is annoyingly reliant on something's general color and shape for recognition (especially in icons like favicons/profile pics), and adding this badge _may_ make it more difficult for me figure out which of my billion tabs has UK on it when I get a ping if I want more details. Its possible that this won't actually impact things, but I would rather have the option than not. Its minor, and I can definitely see the trade-off of settings clutter vs configuration, but I just want to explain why I want the option in a bit more detail.
louislam commented 4 years ago (Migrated from github.com)
Owner

Just tested, it is working.

However, I think using vue's watch should be better and easier. I will come back later.

Just tested, it is working. However, I think using vue's `watch` should be better and easier. I will come back later.

Reviewers

Saibamen
This pull request has changes conflicting with the target branch.
package-lock.json
src/mixins/socket.js
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Saibamen
Labels
Apply labels
Clear labels
bug
Something isn't working dependencies
Pull requests that update a dependency file discussion doc
Improvements or additions to documentation duplicate
This issue or pull request already exists feature-request
New feature or request good first issue
Good for newcomers hacktoberfest hacktoberfest-accepted help help wanted
Extra attention is needed High
High Priority impossible invalid
This doesn't seem right investigating k8s Low
Low Priority Medium
Medium Priority News prerelease bug question
Further information is requested resolved Unknown wontfix
This will not be worked on
No Label bug dependencies discussion doc duplicate feature-request good first issue hacktoberfest hacktoberfest-accepted help help wanted High impossible invalid investigating k8s Low Medium News prerelease bug question resolved Unknown wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'WillianRod/feat/add-favicon-badges'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes