Browse Source
Fix issue with key-rotate (#5348 )
The new web-vault seems to call an extra endpoint, which looks like it is only used when passkeys can be used for login.
Since we do not support this (yet), we can just return an empty data object.
Signed-off-by: BlackDex <black.dex@gmail.com>
pull/4589/head
Mathijs van Veluw
2 weeks ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with
19 additions and
2 deletions
src/api/core/accounts.rs
src/api/core/mod.rs
@ -366,7 +366,12 @@ async fn post_password(data: Json<ChangePassData>, headers: Headers, mut conn: D
& data . new_master_password_hash ,
Some ( data . key ) ,
true ,
Some ( vec ! [ String ::from ( "post_rotatekey" ) , String ::from ( "get_contacts" ) , String ::from ( "get_public_keys" ) ] ) ,
Some ( vec ! [
String ::from ( "post_rotatekey" ) ,
String ::from ( "get_contacts" ) ,
String ::from ( "get_public_keys" ) ,
String ::from ( "get_api_webauthn" ) ,
] ) ,
) ;
let save_result = user . save ( & mut conn ) . await ;
@ -18,7 +18,7 @@ pub use sends::purge_sends;
pub fn routes ( ) -> Vec < Route > {
let mut eq_domains_routes = routes ! [ get_eq_domains , post_eq_domains , put_eq_domains ] ;
let mut hibp_routes = routes ! [ hibp_breach ] ;
let mut meta_routes = routes ! [ alive , now , version , config ] ;
let mut meta_routes = routes ! [ alive , now , version , config , get_api_webauthn ] ;
let mut routes = Vec ::new ( ) ;
routes . append ( & mut accounts ::routes ( ) ) ;
@ -184,6 +184,18 @@ fn version() -> Json<&'static str> {
Json ( crate ::VERSION . unwrap_or_default ( ) )
}
#[ get( " /webauthn " ) ]
fn get_api_webauthn ( _headers : Headers ) -> Json < Value > {
// Prevent a 404 error, which also causes key-rotation issues
// It looks like this is used when login with passkeys is enabled, which Vaultwarden does not (yet) support
// An empty list/data also works fine
Json ( json ! ( {
"object" : "list" ,
"data" : [ ] ,
"continuationToken" : null
} ) )
}
#[ get( " /config " ) ]
fn config ( ) -> Json < Value > {
let domain = crate ::CONFIG . domain ( ) ;