refactor(api): Use `map` for populating Yahoo Finance holdings

apps/api/src/services/data-provider/data-enhancer/yahoo-finance/yahoo-finance.service.ts

@@ -218,14 +218,12 @@ export class YahooFinanceDataEnhancerService implements DataEnhancerInterface {
           }
         }
 
-        response.holdings = [];
-
-        for (const holding of assetProfile.topHoldings.holdings) {
-          response.holdings.push({
+        response.holdings = assetProfile.topHoldings.holdings.map((holding) => {
+          return {
             name: holding.holdingName,
             weight: holding.holdingPercent
+          };
         });
-        }
       } else if (
         assetSubClass === 'STOCK' &&
         assetProfile.summaryProfile?.country