Browse Source

Code review fixes

pull/4892/head
csehatt741 3 weeks ago
committed by Thomas Kaul
parent
commit
31e742b822
  1. 30
      apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts
  2. 3
      libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

30
apps/client/src/app/pages/portfolio/activities/create-or-update-activity-dialog/create-or-update-activity-dialog.component.ts

@ -96,22 +96,28 @@ export class CreateOrUpdateActivityDialog implements OnDestroy {
.sort((a, b) => { .sort((a, b) => {
return a.name?.localeCompare(b.name); return a.name?.localeCompare(b.name);
}) })
.map((holding) => { .map(
({
assetClass,
assetSubClass,
currency,
dataSource,
name,
symbol
}) => {
return { return {
assetClass: holding.assetClass, assetClass,
assetSubClass: holding.assetSubClass, assetSubClass,
currency: holding.currency, currency,
dataProviderInfo: { dataProviderInfo: {
dataSource: holding.dataSource, isPremium: false
isPremium: false,
name: holding.name,
url: holding.url
}, },
dataSource: holding.dataSource, dataSource,
name: holding.name, name,
symbol: holding.symbol symbol
}; };
}); }
);
}); });
this.tagsAvailable = this.tagsAvailable =

3
libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

@ -12,6 +12,7 @@ import {
Component, Component,
ElementRef, ElementRef,
Input, Input,
OnChanges,
OnDestroy, OnDestroy,
OnInit, OnInit,
SimpleChanges, SimpleChanges,
@ -75,7 +76,7 @@ import { GfPremiumIndicatorComponent } from '../premium-indicator';
}) })
export class GfSymbolAutocompleteComponent export class GfSymbolAutocompleteComponent
extends AbstractMatFormField<LookupItem> extends AbstractMatFormField<LookupItem>
implements OnInit, OnDestroy implements OnChanges, OnDestroy, OnInit
{ {
@Input() public defaultLookupItems: LookupItem[] = []; @Input() public defaultLookupItems: LookupItem[] = [];
@Input() public isLoading = false; @Input() public isLoading = false;

Loading…
Cancel
Save