Browse Source

resolve comments

pull/8101/head
KenTandrian 6 days ago
parent
commit
6260405ab0
  1. 5
      apps/client/src/app/components/home-holdings/home-holdings.component.ts
  2. 2
      apps/client/src/app/components/home-overview/home-overview.html
  3. 2
      libs/ui/src/lib/line-chart/line-chart.component.ts

5
apps/client/src/app/components/home-holdings/home-holdings.component.ts

@ -12,8 +12,7 @@ import {
import { hasPermission, permissions } from '@ghostfolio/common/permissions'; import { hasPermission, permissions } from '@ghostfolio/common/permissions';
import { internalRoutes } from '@ghostfolio/common/routes/routes'; import { internalRoutes } from '@ghostfolio/common/routes/routes';
import { hasScope, scopes } from '@ghostfolio/common/scopes'; import { hasScope, scopes } from '@ghostfolio/common/scopes';
import type { import {
DateRange,
HoldingType, HoldingType,
HoldingsViewMode, HoldingsViewMode,
ToggleOption ToggleOption
@ -66,7 +65,7 @@ export class GfHomeHoldingsComponent implements OnInit {
return this.user()?.settings?.colorScheme; return this.user()?.settings?.colorScheme;
}); });
protected readonly dateRange = computed<DateRange>(() => { protected readonly dateRange = computed(() => {
return this.user()?.settings?.dateRange ?? DEFAULT_DATE_RANGE; return this.user()?.settings?.dateRange ?? DEFAULT_DATE_RANGE;
}); });

2
apps/client/src/app/components/home-overview/home-overview.html

@ -73,7 +73,7 @@
[class.pr-3]="deviceType() === 'mobile'" [class.pr-3]="deviceType() === 'mobile'"
[colorScheme]="user()?.settings?.colorScheme" [colorScheme]="user()?.settings?.colorScheme"
[hidden]="historicalDataItems()?.length === 0" [hidden]="historicalDataItems()?.length === 0"
[historicalDataItems]="historicalDataItems() ?? []" [historicalDataItems]="historicalDataItems()"
[isAnimated]="user()?.settings?.dateRange === '1d' ? false : true" [isAnimated]="user()?.settings?.dateRange === '1d' ? false : true"
[label]="performanceLabel" [label]="performanceLabel"
[locale]="locale()" [locale]="locale()"

2
libs/ui/src/lib/line-chart/line-chart.component.ts

@ -60,7 +60,7 @@ export class GfLineChartComponent
@Input() benchmarkLabel = ''; @Input() benchmarkLabel = '';
@Input() colorScheme?: ColorScheme; @Input() colorScheme?: ColorScheme;
@Input() currency?: string; @Input() currency?: string;
@Input() historicalDataItems: LineChartItem[]; @Input() historicalDataItems: LineChartItem[] | null;
@Input() isAnimated = false; @Input() isAnimated = false;
@Input() label: string; @Input() label: string;
@Input() locale = getLocale(); @Input() locale = getLocale();

Loading…
Cancel
Save