Browse Source

style: mark comments as TODOs

Signed-off-by: Dominik Willner <th33xitus@gmail.com>
pull/3878/head
dw-0 11 months ago
parent
commit
7078dd5c72
  1. 2
      .eslintrc.json
  2. 5
      apps/client/tsconfig.json
  3. 9
      libs/ui/tsconfig.json
  4. 3
      tsconfig.base.json

2
.eslintrc.json

@ -147,7 +147,7 @@
"@typescript-eslint/consistent-type-definitions": "warn", "@typescript-eslint/consistent-type-definitions": "warn",
"@typescript-eslint/prefer-function-type": "warn", "@typescript-eslint/prefer-function-type": "warn",
"@typescript-eslint/no-empty-function": "warn", "@typescript-eslint/no-empty-function": "warn",
"@typescript-eslint/prefer-nullish-coalescing": "warn", // requires strictNullChecks: true "@typescript-eslint/prefer-nullish-coalescing": "warn", // TODO: Requires strictNullChecks: true
"@typescript-eslint/consistent-type-assertions": "warn", "@typescript-eslint/consistent-type-assertions": "warn",
"@typescript-eslint/prefer-optional-chain": "warn", "@typescript-eslint/prefer-optional-chain": "warn",
"@typescript-eslint/consistent-indexed-object-style": "warn", "@typescript-eslint/consistent-indexed-object-style": "warn",

5
apps/client/tsconfig.json

@ -15,8 +15,9 @@
], ],
"angularCompilerOptions": { "angularCompilerOptions": {
"strictInjectionParameters": true, "strictInjectionParameters": true,
"strictInputAccessModifiers": false, // todo: enable strict input access modifiers // TODO: Enable stricter rules for this project
"strictTemplates": false // todo: enable strict templates "strictInputAccessModifiers": false,
"strictTemplates": false
}, },
"compilerOptions": { "compilerOptions": {
"target": "es2020" "target": "es2020"

9
libs/ui/tsconfig.json

@ -14,10 +14,11 @@
} }
], ],
"compilerOptions": { "compilerOptions": {
"strict": false, // remove once solved in tsconfig.base.json "target": "es2020",
"noImplicitReturns": true, // remove once solved in tsconfig.base.json // TODO: Remove once solved in tsconfig.base.json
"noFallthroughCasesInSwitch": true, // remove once solved in tsconfig.base.json "strict": false,
"target": "es2020" "noImplicitReturns": true,
"noFallthroughCasesInSwitch": true
}, },
"angularCompilerOptions": { "angularCompilerOptions": {
"strictInjectionParameters": true, "strictInjectionParameters": true,

3
tsconfig.base.json

@ -23,7 +23,6 @@
}, },
"noFallthroughCasesInSwitch": true, "noFallthroughCasesInSwitch": true,
"forceConsistentCasingInFileNames": true, "forceConsistentCasingInFileNames": true,
// set to true to enable stricter type checking for this project
"strict": false, "strict": false,
"strictNullChecks": false, "strictNullChecks": false,
"strictPropertyInitialization": false, "strictPropertyInitialization": false,
@ -34,7 +33,7 @@
"noPropertyAccessFromIndexSignature": false, "noPropertyAccessFromIndexSignature": false,
"noUnusedLocals": false, "noUnusedLocals": false,
"noUnusedParameters": false, "noUnusedParameters": false,
"allowUnreachableCode": true // set to false for stricter type checking "allowUnreachableCode": true
}, },
"exclude": ["node_modules", "tmp"] "exclude": ["node_modules", "tmp"]
} }

Loading…
Cancel
Save