Browse Source
Bugfix/add missing guards in getSettings() of static portfolio analysis rules (#5368)
* Add missing guards
pull/5369/head
Thomas Kaul
5 days ago
committed by
GitHub
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with
7 additions and
7 deletions
-
apps/api/src/models/rules/account-cluster-risk/current-investment.ts
-
apps/api/src/models/rules/account-cluster-risk/single-account.ts
-
apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts
-
apps/api/src/models/rules/currency-cluster-risk/current-investment.ts
-
apps/api/src/models/rules/emergency-fund/emergency-fund-setup.ts
-
apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts
-
apps/api/src/models/rules/liquidity/buying-power.ts
|
|
@ -124,7 +124,7 @@ export class AccountClusterRiskCurrentInvestment extends Rule<Settings> { |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true, |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true, |
|
|
|
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5 |
|
|
|
}; |
|
|
|
} |
|
|
|
|
|
@ -74,7 +74,7 @@ export class AccountClusterRiskSingleAccount extends Rule<RuleSettings> { |
|
|
|
|
|
|
|
public getSettings({ xRayRules }: UserSettings): RuleSettings { |
|
|
|
return { |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true |
|
|
|
}; |
|
|
|
} |
|
|
|
} |
|
|
|
|
|
@ -100,7 +100,7 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule<Setti |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true |
|
|
|
}; |
|
|
|
} |
|
|
|
} |
|
|
|
|
|
@ -101,7 +101,7 @@ export class CurrencyClusterRiskCurrentInvestment extends Rule<Settings> { |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true, |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true, |
|
|
|
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.5 |
|
|
|
}; |
|
|
|
} |
|
|
|
|
|
@ -62,7 +62,7 @@ export class EmergencyFundSetup extends Rule<Settings> { |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true |
|
|
|
}; |
|
|
|
} |
|
|
|
} |
|
|
|
|
|
@ -85,7 +85,7 @@ export class FeeRatioInitialInvestment extends Rule<Settings> { |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true, |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true, |
|
|
|
thresholdMax: xRayRules?.[this.getKey()]?.thresholdMax ?? 0.01 |
|
|
|
}; |
|
|
|
} |
|
|
|
|
|
@ -78,7 +78,7 @@ export class BuyingPower extends Rule<Settings> { |
|
|
|
public getSettings({ baseCurrency, xRayRules }: UserSettings): Settings { |
|
|
|
return { |
|
|
|
baseCurrency, |
|
|
|
isActive: xRayRules?.[this.getKey()].isActive ?? true, |
|
|
|
isActive: xRayRules?.[this.getKey()]?.isActive ?? true, |
|
|
|
thresholdMin: xRayRules?.[this.getKey()]?.thresholdMin ?? 0 |
|
|
|
}; |
|
|
|
} |
|
|
|