Browse Source

Improve search log output for unsupported queries

pull/7480/head
Thomas Kaul 1 month ago
parent
commit
9220a353e9
  1. 6
      apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts
  2. 2
      apps/api/src/services/data-provider/data-provider.service.ts
  3. 10
      apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts
  4. 4
      libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

6
apps/api/src/app/endpoints/data-providers/ghostfolio/ghostfolio.service.ts

@ -342,7 +342,7 @@ export class GhostfolioService {
query = query?.trim();
if (!query) {
if (!query || query.length < 2) {
return results;
}
@ -350,10 +350,6 @@ export class GhostfolioService {
let lookupItems: LookupItem[] = [];
const promises: Promise<{ items: LookupItem[] }>[] = [];
if (query?.length < 2) {
return { items: lookupItems };
}
for (const dataProviderService of this.getDataProviderServices()) {
promises.push(
dataProviderService.search({

2
apps/api/src/services/data-provider/data-provider.service.ts

@ -840,7 +840,7 @@ export class DataProviderService implements OnModuleInit {
query = query?.trim();
if (query?.length < 2) {
if (!query || query.length < 2) {
return { items: lookupItems };
}

10
apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

@ -330,13 +330,13 @@ export class YahooFinanceService implements DataProviderInterface {
});
}
} catch (error) {
let message = error;
if (error?.name === 'BadRequestError') {
message = `RequestError: The search for "${query}" is not supported`;
this.logger.warn(
`The search for "${query}" is not supported: ${error.message}`
);
} else {
this.logger.error(error);
}
this.logger.error(message);
}
return { items };

4
libs/ui/src/lib/symbol-autocomplete/symbol-autocomplete.component.ts

@ -141,13 +141,13 @@ export class GfSymbolAutocompleteComponent
return isString(query);
}),
debounceTime(400),
distinctUntilChanged(),
tap(() => {
this.isLoading = true;
this.changeDetectorRef.markForCheck();
}),
debounceTime(400),
distinctUntilChanged(),
takeUntilDestroyed(this.destroyRef),
switchMap((query: string) => {
return this.dataService.fetchSymbols({

Loading…
Cancel
Save