Browse Source

Minor improvements

pull/4313/head
Thomas Kaul 6 months ago
parent
commit
a7bfc4ae46
  1. 10
      apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts

10
apps/api/src/models/rules/regional-market-cluster-risk/asia-pacific.ts

@ -15,11 +15,11 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule<Settings> {
) { ) {
super(exchangeRateDataService, { super(exchangeRateDataService, {
key: RegionalMarketClusterRiskAsiaPacific.name, key: RegionalMarketClusterRiskAsiaPacific.name,
name: 'Asia Pacific' name: 'Asia-Pacific'
}); });
this.currentValueInBaseCurrency = currentValueInBaseCurrency;
this.asiaPacificValueInBaseCurrency = asiaPacificValueInBaseCurrency; this.asiaPacificValueInBaseCurrency = asiaPacificValueInBaseCurrency;
this.currentValueInBaseCurrency = currentValueInBaseCurrency;
} }
public evaluate(ruleSettings: Settings) { public evaluate(ruleSettings: Settings) {
@ -29,14 +29,14 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule<Settings> {
if (asiaPacificMarketValueRatio > ruleSettings.thresholdMax) { if (asiaPacificMarketValueRatio > ruleSettings.thresholdMax) {
return { return {
evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) exceeds ${( evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) exceeds ${(
ruleSettings.thresholdMax * 100 ruleSettings.thresholdMax * 100
).toPrecision(3)}%`, ).toPrecision(3)}%`,
value: false value: false
}; };
} else if (asiaPacificMarketValueRatio < ruleSettings.thresholdMin) { } else if (asiaPacificMarketValueRatio < ruleSettings.thresholdMin) {
return { return {
evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is below ${( evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is below ${(
ruleSettings.thresholdMin * 100 ruleSettings.thresholdMin * 100
).toPrecision(3)}%`, ).toPrecision(3)}%`,
value: false value: false
@ -44,7 +44,7 @@ export class RegionalMarketClusterRiskAsiaPacific extends Rule<Settings> {
} }
return { return {
evaluation: `The Asia Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is within the range of ${( evaluation: `The Asia-Pacific market contribution of your current investment (${(asiaPacificMarketValueRatio * 100).toPrecision(3)}%) is within the range of ${(
ruleSettings.thresholdMin * 100 ruleSettings.thresholdMin * 100
).toPrecision( ).toPrecision(
3 3

Loading…
Cancel
Save