Browse Source

code review changes

pull/5090/head
csehatt741 2 months ago
parent
commit
f1ede36ae9
  1. 8
      apps/client/src/app/components/header/header.component.ts
  2. 4
      apps/client/src/app/pages/about/overview/about-overview-page.component.ts
  3. 2
      apps/client/src/app/pages/about/overview/about-overview-page.html
  4. 3
      apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts
  5. 2
      apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts
  6. 3
      apps/client/src/app/pages/register/register-page-routing.module.ts
  7. 2
      apps/client/src/app/pages/register/register-page.module.ts

8
apps/client/src/app/components/header/header.component.ts

@ -36,8 +36,8 @@ import {
menuOutline, menuOutline,
optionsOutline, optionsOutline,
personCircleOutline, personCircleOutline,
radioButtonOnOutline, radioButtonOffOutline,
radioButtonOffOutline radioButtonOnOutline
} from 'ionicons/icons'; } from 'ionicons/icons';
import { EMPTY, Subject } from 'rxjs'; import { EMPTY, Subject } from 'rxjs';
import { catchError, takeUntil } from 'rxjs/operators'; import { catchError, takeUntil } from 'rxjs/operators';
@ -133,8 +133,8 @@ export class HeaderComponent implements OnChanges {
menuOutline, menuOutline,
optionsOutline, optionsOutline,
personCircleOutline, personCircleOutline,
radioButtonOnOutline, radioButtonOffOutline,
radioButtonOffOutline radioButtonOnOutline
}); });
} }

4
apps/client/src/app/pages/about/overview/about-overview-page.component.ts

@ -19,7 +19,7 @@ import { addIcons } from 'ionicons';
import { import {
logoGithub, logoGithub,
logoLinkedin, logoLinkedin,
logoStackoverflow, logoSlack,
logoX, logoX,
mail mail
} from 'ionicons/icons'; } from 'ionicons/icons';
@ -62,7 +62,7 @@ export class AboutOverviewPageComponent implements OnDestroy, OnInit {
permissions.enableSubscription permissions.enableSubscription
); );
addIcons({ logoGithub, logoLinkedin, logoStackoverflow, logoX, mail }); addIcons({ logoGithub, logoLinkedin, logoSlack, logoX, mail });
} }
public ngOnInit() { public ngOnInit() {

2
apps/client/src/app/pages/about/overview/about-overview-page.html

@ -81,7 +81,7 @@
mat-icon-button mat-icon-button
title="Join the Ghostfolio Slack community" title="Join the Ghostfolio Slack community"
> >
<ion-icon name="logo-stackoverflow" /> <ion-icon name="logo-slack" />
</a> </a>
<a <a
class="mx-2" class="mx-2"

3
apps/client/src/app/pages/portfolio/x-ray/x-ray-page-routing.module.ts

@ -2,7 +2,6 @@ import { AuthGuard } from '@ghostfolio/client/core/auth.guard';
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router'; import { RouterModule, Routes } from '@angular/router';
import { IonIcon } from '@ionic/angular/standalone';
import { XRayPageComponent } from './x-ray-page.component'; import { XRayPageComponent } from './x-ray-page.component';
@ -16,7 +15,7 @@ const routes: Routes = [
]; ];
@NgModule({ @NgModule({
imports: [IonIcon, RouterModule.forChild(routes)], imports: [RouterModule.forChild(routes)],
exports: [RouterModule] exports: [RouterModule]
}) })
export class XRayPageRoutingModule {} export class XRayPageRoutingModule {}

2
apps/client/src/app/pages/portfolio/x-ray/x-ray-page.module.ts

@ -3,6 +3,7 @@ import { GfPremiumIndicatorComponent } from '@ghostfolio/ui/premium-indicator';
import { CommonModule } from '@angular/common'; import { CommonModule } from '@angular/common';
import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
import { IonIcon } from '@ionic/angular/standalone';
import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader'; import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
import { XRayPageRoutingModule } from './x-ray-page-routing.module'; import { XRayPageRoutingModule } from './x-ray-page-routing.module';
@ -14,6 +15,7 @@ import { XRayPageComponent } from './x-ray-page.component';
CommonModule, CommonModule,
GfPremiumIndicatorComponent, GfPremiumIndicatorComponent,
GfRulesModule, GfRulesModule,
IonIcon,
NgxSkeletonLoaderModule, NgxSkeletonLoaderModule,
XRayPageRoutingModule XRayPageRoutingModule
], ],

3
apps/client/src/app/pages/register/register-page-routing.module.ts

@ -3,7 +3,6 @@ import { publicRoutes } from '@ghostfolio/common/routes/routes';
import { NgModule } from '@angular/core'; import { NgModule } from '@angular/core';
import { RouterModule, Routes } from '@angular/router'; import { RouterModule, Routes } from '@angular/router';
import { IonIcon } from '@ionic/angular/standalone';
import { RegisterPageComponent } from './register-page.component'; import { RegisterPageComponent } from './register-page.component';
@ -17,7 +16,7 @@ const routes: Routes = [
]; ];
@NgModule({ @NgModule({
imports: [IonIcon, RouterModule.forChild(routes)], imports: [RouterModule.forChild(routes)],
exports: [RouterModule] exports: [RouterModule]
}) })
export class RegisterPageRoutingModule {} export class RegisterPageRoutingModule {}

2
apps/client/src/app/pages/register/register-page.module.ts

@ -4,6 +4,7 @@ import { CommonModule } from '@angular/common';
import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
import { MatButtonModule } from '@angular/material/button'; import { MatButtonModule } from '@angular/material/button';
import { RouterModule } from '@angular/router'; import { RouterModule } from '@angular/router';
import { IonIcon } from '@ionic/angular/standalone';
import { RegisterPageRoutingModule } from './register-page-routing.module'; import { RegisterPageRoutingModule } from './register-page-routing.module';
import { RegisterPageComponent } from './register-page.component'; import { RegisterPageComponent } from './register-page.component';
@ -14,6 +15,7 @@ import { ShowAccessTokenDialogModule } from './show-access-token-dialog/show-acc
imports: [ imports: [
CommonModule, CommonModule,
GfLogoComponent, GfLogoComponent,
IonIcon,
MatButtonModule, MatButtonModule,
RegisterPageRoutingModule, RegisterPageRoutingModule,
RouterModule, RouterModule,

Loading…
Cancel
Save