Browse Source

address pr comments

pull/4321/head
Shaunak 6 months ago
parent
commit
fa39d2d2f3
  1. 1
      apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts
  2. 6
      libs/ui/src/lib/assistant/assistant.html
  3. 1
      libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts
  4. 11
      libs/ui/src/lib/value/value.component.html

1
apps/client/src/app/components/asset-profile-icon/asset-profile-icon.component.ts

@ -9,7 +9,6 @@ import { DataSource } from '@prisma/client';
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
imports: [],
schemas: [CUSTOM_ELEMENTS_SCHEMA], schemas: [CUSTOM_ELEMENTS_SCHEMA],
selector: 'gf-asset-profile-icon', selector: 'gf-asset-profile-icon',
styleUrls: ['./asset-profile-icon.component.scss'], styleUrls: ['./asset-profile-icon.component.scss'],

6
libs/ui/src/lib/assistant/assistant.html

@ -61,8 +61,7 @@
width: '100%' width: '100%'
}" }"
/> />
} } @else {
@if (!isLoading) {
<div class="px-2 py-1" i18n>No entries...</div> <div class="px-2 py-1" i18n>No entries...</div>
} }
} }
@ -90,8 +89,7 @@
width: '100%' width: '100%'
}" }"
/> />
} } @else {
@if (!isLoading) {
<div class="px-2 py-1" i18n>No entries...</div> <div class="px-2 py-1" i18n>No entries...</div>
} }
} }

1
libs/ui/src/lib/data-provider-credits/data-provider-credits.component.ts

@ -9,7 +9,6 @@ import {
@Component({ @Component({
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
imports: [],
schemas: [CUSTOM_ELEMENTS_SCHEMA], schemas: [CUSTOM_ELEMENTS_SCHEMA],
selector: 'gf-data-provider-credits', selector: 'gf-data-provider-credits',
styleUrls: ['./data-provider-credits.component.scss'], styleUrls: ['./data-provider-credits.component.scss'],

11
libs/ui/src/lib/value/value.component.html

@ -33,8 +33,7 @@
{{ formattedValue }}% {{ formattedValue }}%
} }
</div> </div>
} } @else {
@if (!isPercent) {
<div <div
class="mb-0 value" class="mb-0 value"
[ngClass]="{ [ngClass]="{
@ -50,16 +49,17 @@
</div> </div>
} }
@if (unit && size === 'medium') { @if (unit && size === 'medium') {
@if (size === 'medium') {
<small class="ml-1"> <small class="ml-1">
{{ unit }} {{ unit }}
</small> </small>
} } @else {
@if (unit && size !== 'medium') {
<div class="ml-1"> <div class="ml-1">
{{ unit }} {{ unit }}
</div> </div>
} }
} }
}
@if (isString) { @if (isString) {
<div <div
class="mb-0 text-truncate value" class="mb-0 text-truncate value"
@ -95,8 +95,7 @@
<span class="text-muted"> {{ subLabel }}</span> <span class="text-muted"> {{ subLabel }}</span>
} }
</div> </div>
} } @else {
@if (size !== 'large') {
<small class="d-block text-truncate"> <small class="d-block text-truncate">
<ng-container *ngTemplateOutlet="label"></ng-container> <ng-container *ngTemplateOutlet="label"></ng-container>
</small> </small>

Loading…
Cancel
Save