Sven Günther
							
						 
						
							
							
							
								
							
								c8afec7319 
								
							
								 
							
						 
						
							
							
								
								Address PR  #5670  review feedback  
							
							 
							
							
								
 
							
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Sven Günther
							
						 
						
							
							
							
								
							
								e93b4644af 
								
							
								 
							
						 
						
							
							
								
								fix issue  #5419  
							
							 
							
							 
							
							
								
 
							
							
							Root Causes
  Issue 1: Import Validation Failure
  - The validateActivities() method (called at apps/api/src/app/import/import.service.ts#L374) validates activities before
  asset profiles from the import file are created in the database (apps/api/src/app/import/import.service.ts#L245)
  - For MANUAL data source, ManualService.getAssetProfile() queries the database, which returns undefined for new profiles
  - Validation at apps/api/src/app/import/import.service.ts#L774 requires assetProfile.name to exist, causing import to fail
  Issue 2: Empty Name Column
  - Even if validation passes, the validateActivities() method only checked for the existence of the name but didn't populate
  it from the import data
  - The asset profile object used for display lacked the complete profile information from the import file
Solution
  Modified apps/api/src/app/import/import.service.ts:
  1. Pass import data to validation (apps/api/src/app/import/import.service.ts#L376)
    - Added assetProfilesWithMarketDataDto parameter to validateActivities() call
  2. Check import data during validation (apps/api/src/app/import/import.service.ts#L755)
    - When asset profile doesn't exist in database (no name), check if it exists in import data
    - If found in import data, merge all asset profile fields (name, currency, assetClass, etc.) into the validation object
    - This ensures the name and other fields are available for display in the UI
  3. Maintain validation rules (apps/api/src/app/import/import.service.ts#L788)
    - Keep existing validation that requires name for non-MANUAL BUY, DIVIDEND, and SELL activities
    - Separate the data population logic from validation logic 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								948233c651 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/remove @IsOptional() from dataSource in CreateOrderDto ( #5703 )  
							
							 
							
							 
							
							
								
 
							
							
							* Remove is @IsOptional() from dataSource 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								ab7f1fd881 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/set up GitHub Sponsors ( #5723 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add github 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Shivansh Pandey
							
						 
						
							
							
								
								
							
							
								
							
								94e8a7c6bc 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/add support for configuring safe withdrawal rate ( #5679 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add support for configuring safe withdrawal rate
* Update changelog 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Ayush Jain
							
						 
						
							
							
								
								
							
							
								
							
								b168a9e3c1 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/create infinite logo carousel component ( #5671 )  
							
							 
							
							 
							
							
								
 
							
							
							* Create infinite logo carousel component
* Update changelog 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								7642d82318 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/add missing type of access id in get public portfolio endpoint ( #5690 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add missing type 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Szymon Łągiewka
							
						 
						
							
							
								
								
							
							
								
							
								7761c764b5 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/fix server startup message to properly display IPv6 addresses ( #5716 )  
							
							 
							
							 
							
							
								
 
							
							
							* Fix server startup message to properly display IPv6 addresses
* Update changelog 
							
						 
						3 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								94f3d64891 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/refactor various components to self-closing tags ( #5704 )  
							
							 
							
							 
							
							
								
 
							
							
							* Refactor to self-closing tags
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								0666716fc6 
								
									
								
							
								 
							
						 
						
							
							
								
								Release 2.207.0 ( #5707 )  
							
							 
							
							
								
 
							
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								github-actions[bot]
							
						 
						
							
							
								
								
							
							
								
							
								022187eacc 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/update locales ( #5634 )  
							
							 
							
							 
							
							
								
 
							
							
							* Update locales
* Update translations
* Update changelog
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Tanbir Ali
							
						 
						
							
							
								
								
							
							
								
							
								b829442f55 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/prefix markets component ( #5705 )  
							
							 
							
							 
							
							
								
 
							
							
							* Prefix markets component 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								a6f34b51b0 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/simplify action buttons in create or update access dialog ( #5706 )  
							
							 
							
							 
							
							
								
 
							
							
							* Simplify action buttons 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								5bb22e840d 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/fix word wrap in various menus ( #5691 )  
							
							 
							
							 
							
							
								
 
							
							
							* Fix word wrap
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Raj Gupta
							
						 
						
							
							
								
								
							
							
								
							
								a281ec825b 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/extend Storybook stories of accounts table component by loading state story ( #5696 )  
							
							 
							
							 
							
							
								
 
							
							
							* Extend Storybook stories of accounts table component by loading state story
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Bence Hornyák
							
						 
						
							
							
								
								
							
							
								
							
								0e43bb048a 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/introduce tabs in asset profile dialog ( #5693 )  
							
							 
							
							 
							
							
								
 
							
							
							* Introduce tabs in asset profile dialog
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								SK Akram
							
						 
						
							
							
								
								
							
							
								
							
								e6ff0f65c2 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/migrate auth page component to standalone ( #5695 )  
							
							 
							
							 
							
							
								
 
							
							
							* Migrate auth page component to standalone
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Germán Martín
							
						 
						
							
							
								
								
							
							
								
							
								20a756a376 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/add support to update granted access ( #5566 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add support to update granted access
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								baf8daaad7 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve spacing of buttons in button container of holding detail dialog ( #5692 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve spacing
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								David Requeno
							
						 
						
							
							
								
								
							
							
								
							
								5d65906722 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/set up Storybook stories for activities table component ( #5610 )  
							
							 
							
							 
							
							
								
 
							
							
							* Set up Storybook stories for activities table component
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								180e0f3c81 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/add date range query parameter to data gathering endpoint ( #5684 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add date range
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								400d4ae7b4 
								
									
								
							
								 
							
						 
						
							
							
								
								Release 2.206.0 ( #5683 )  
							
							 
							
							
								
 
							
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								6dc7edb7b5 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/clean up unused import in holdings table component ( #5682 )  
							
							 
							
							 
							
							
								
 
							
							
							* Clean up 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Aditya Garud
							
						 
						
							
							
								
								
							
							
								
							
								2248eb77f9 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/preselect first search result item in assistant ( #5656 )  
							
							 
							
							 
							
							
								
 
							
							
							* Preselect first search result item in assistant
* Update changelog 
							
						 
						4 weeks ago  
					 
				
					
						
							
							
								 
								Malay Kumar
							
						 
						
							
							
								
								
							
							
								
							
								d715143299 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/add value components to rule settings dialog ( #5653 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add value components to rule settings dialog
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								4256cdee34 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/add missing CommonModule import in import activities dialog ( #5674 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add missing CommonModule import
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								SK Akram
							
						 
						
							
							
								
								
							
							
								
							
								3f2d045e1f 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/migrate file drop directive to standalone ( #5646 )  
							
							 
							
							 
							
							
								
 
							
							
							* Migrate file drop directive to standalone
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								s-vamshi
							
						 
						
							
							
								
								
							
							
								
							
								f122bd996b 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/migrate open page component to standalone ( #5645 )  
							
							 
							
							 
							
							
								
 
							
							
							* Migrate open page component to standalone
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Flavien Lankai-Mills
							
						 
						
							
							
								
								
							
							
								
							
								c173998677 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/refactor fire wealth from number to object in portfolio summary interface ( #5644 )  
							
							 
							
							 
							
							
								
 
							
							
							* Refactor fire wealth from number to object in portfolio summary interface
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Raj Gupta
							
						 
						
							
							
								
								
							
							
								
							
								15133466a5 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/migrate symbol pipe to standalone ( #5637 )  
							
							 
							
							 
							
							
								
 
							
							
							* Migrate symbol pipe to standalone
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								b61f470854 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/fix exception in get asset profile functionality of FMP service ( #5663 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add missing guard
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Mariam Saeed
							
						 
						
							
							
								
								
							
							
								
							
								4e2a1b8de5 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve usability of create watchlist item dialog ( #5661 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve usability of create watchlist item dialog
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								4f51253b7e 
								
									
								
							
								 
							
						 
						
							
							
								
								Release 2.205.0 ( #5654 )  
							
							 
							
							
								
 
							
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Omar Eltomy
							
						 
						
							
							
								
								
							
							
								
							
								244e63a127 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/restrict retirement date picker of FIRE calculator to future dates ( #5627 )  
							
							 
							
							 
							
							
								
 
							
							
							* Restrict retirement date picker of FIRE calculator to future dates
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								3cbbbb7c1e 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/upgrade prisma to version 6.16.3 ( #5652 )  
							
							 
							
							 
							
							
								
 
							
							
							* Upgrade prisma to version 6.16.3
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								e9c42598db 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve support for mutual funds in FMP service ( #5651 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve support for mutual funds in getAssetProfile()
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								bb139bcfe6 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve language localization for de 20250930 ( #5638 )  
							
							 
							
							 
							
							
								
 
							
							
							* Update translations
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Jasmeet Singh
							
						 
						
							
							
								
								
							
							
								
							
								3c1118e027 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/prefix home market component with Gf ( #5643 )  
							
							 
							
							 
							
							
								
 
							
							
							* Prefix home market component with Gf 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Flavien Lankai-Mills
							
						 
						
							
							
								
								
							
							
								
							
								8b7ad34506 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/add component suffix to create or update access dialog component ( #5621 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add component suffix 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								SK Akram
							
						 
						
							
							
								
								
							
							
								
							
								0a79a27e0d 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/prefix home watchlist component with Gf ( #5640 )  
							
							 
							
							 
							
							
								
 
							
							
							* Prefix home watchlist component with Gf 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Anirban Biswas
							
						 
						
							
							
								
								
							
							
								
							
								5375d0fee1 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/add component suffix to create or update activity dialog component ( #5628 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add component suffix 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								CodeySnooze
							
						 
						
							
							
								
								
							
							
								
							
								ce1560751e 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/add component suffix to import activities dialog component ( #5620 )  
							
							 
							
							 
							
							
								
 
							
							
							* Add component suffix 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								SK Akram
							
						 
						
							
							
								
								
							
							
								
							
								dcd2d17908 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/prefix create watchlist item dialog component with Gf ( #5617 )  
							
							 
							
							 
							
							
								
 
							
							
							* Prefix create watchlist item dialog component 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								27b6afc1ab 
								
									
								
							
								 
							
						 
						
							
							
								
								Release 2.204.0 ( #5636 )  
							
							 
							
							
								
 
							
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								d242da13d3 
								
									
								
							
								 
							
						 
						
							
							
								
								Release 2.204.0 ( #5635 )  
							
							 
							
							
								
 
							
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Germán Martín
							
						 
						
							
							
								
								
							
							
								
							
								01aeefd2df 
								
									
								
							
								 
							
						 
						
							
							
								
								Bugfix/improve table headers’ alignment of activities table ( #5580 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve table headers’ alignment of activities table
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								0c65afeb22 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve usability of create asset profile dialog in market data section of admin control panel ( #5613 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve usability
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								Thomas Kaul
							
						 
						
							
							
								
								
							
							
								
							
								8f923d0486 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/improve number formatting of y-axis in investment chart component ( #5633 )  
							
							 
							
							 
							
							
								
 
							
							
							* Improve number formatting of y-axis
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								David Requeno
							
						 
						
							
							
								
								
							
							
								
							
								da80efa0c6 
								
									
								
							
								 
							
						 
						
							
							
								
								Task/localize number formatting of y-axis labels in line chart component ( #5624 )  
							
							 
							
							 
							
							
								
 
							
							
							* Localize number formatting of y-axis labels in line chart component
* Update changelog 
							
						 
						1 month ago  
					 
				
					
						
							
							
								 
								github-actions[bot]
							
						 
						
							
							
								
								
							
							
								
							
								abb4ddc942 
								
									
								
							
								 
							
						 
						
							
							
								
								Feature/update locales ( #5631 )  
							
							 
							
							 
							
							
								
 
							
							
							* Update locales
* Update translations
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> 
							
						 
						1 month ago