Browse Source

Pull request feedback from @butlerx

pull/217/head
Ben Letchford 5 years ago
parent
commit
5eae5b5479
  1. 4
      .github/workflows/test.yml
  2. 6
      src/client/download.ts

4
.github/workflows/test.yml

@ -1,5 +1,5 @@
--- ---
on: [push, pull_request] on: [pull_request]
name: Run tests name: Run tests
jobs: jobs:
@ -14,6 +14,8 @@ jobs:
node-version: 12 node-version: 12
- run: yarn - run: yarn
name: Install dependencies name: Install dependencies
- name: ESLint checks
run: yarn lint
- run: yarn build - run: yarn build
name: Compile Typescript name: Compile Typescript
- run: yarn test - run: yarn test

6
src/client/download.ts

@ -87,11 +87,7 @@ export class FileDownloader {
) { ) {
return data; return data;
} }
let newData = ''; return data.split('').map(this.bufferCharacter.bind(this)).join('')
for (let i = 0; i < data.length; i += 1) {
newData += this.bufferCharacter(data[i]);
}
return newData;
} }
onCompleteFile(bufferCharacters: string) { onCompleteFile(bufferCharacters: string) {

Loading…
Cancel
Save